-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 5.6 #2835
API 5.6 #2835
Conversation
Also fix a message entity fixture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick PR!
- which fixture did you fix ragarding message entities?
- I guess
test_bot
is yet to be adapted? :D
Thanks for the quick review!
See
I'm not sure what more to change in it, i'll see |
ah, you mean
well, currently codecov complains about all the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Apart from nitpicking, I guess it's ready, though I'd like for @Poolitzer to have a look as well.
just double checking: are you both comfortable with postponing Defaults.protect_content
to v14? If you prefer to include it directly, we can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Im comfortable with postponing Defaults, jup.
pain in the ass -_- |
what? |
Checklist for PRs
.. versionadded:: version
,.. versionchanged:: version
or.. deprecated:: version
to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst
(optional)If the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrs
and corresponding documentation__init__
accepts**_kwargs
Added new shortcuts:
Chat
&User
for all methods that acceptchat/user_id
Message
for all methods that acceptchat_id
andmessage_id
Message
shortcuts: Addedquote
argument if methods acceptsreply_to_message_id
CallbackQuery
for all methods that accept eitherchat_id
andmessage_id
orinline_message_id
If relevant:
telegram.constants
and shortcuts to them as class variablesREADME.rst
andREADME_RAW.rst
(including the badge), as well astelegram.constants.BOT_API_VERSION
tg.ext.Bot
for new methods that either accept areply_markup
in some form or have a return type that is/containstelegram.Message